VKUI icon indicating copy to clipboard operation
VKUI copied to clipboard

feat(Popover): add anchorRef prop

Open EldarMuhamethanov opened this issue 1 year ago • 5 comments

  • close #6891

  • [x] Документация фичи

Описание

Нужно добавить пропс для компонента Popover с помощью которого можно указать элемент, относительно которого будет позиционироваться поповер

Изменения

Добавил пропс anchorRef в компонент Popover. При передаче его, поповер будет позиционироваться относительно указанного элемента

EldarMuhamethanov avatar Jul 01 '24 13:07 EldarMuhamethanov

size-limit report 📦

Path Size
JS 381.86 KB (+0.31% 🔺)
JS (gzip) 115.6 KB (+0.29% 🔺)
JS (brotli) 94.91 KB (+0.34% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 309.06 KB (0%)
CSS (gzip) 39.64 KB (0%)
CSS (brotli) 31.86 KB (0%)

github-actions[bot] avatar Jul 01 '24 13:07 github-actions[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jul 01 '24 13:07 codesandbox-ci[bot]

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

github-actions[bot] avatar Jul 01 '24 13:07 github-actions[bot]

👀 Docs deployed

Commit cfcbff4d74fed82643a8cd774d265462f0de9adb

github-actions[bot] avatar Jul 01 '24 13:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.15%. Comparing base (7a9018e) to head (cfcbff4). Report is 119 commits behind head on master.

Files with missing lines Patch % Lines
.../vkui/src/components/Popover/PopoverWithAnchor.tsx 90.90% 4 Missing :warning:
packages/vkui/src/components/Popover/Popover.tsx 85.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7113      +/-   ##
==========================================
- Coverage   95.17%   95.15%   -0.02%     
==========================================
  Files         384      386       +2     
  Lines       11212    11269      +57     
  Branches     3674     3697      +23     
==========================================
+ Hits        10671    10723      +52     
- Misses        541      546       +5     
Flag Coverage Δ
unittests 95.15% <91.66%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 01 '24 13:07 codecov[bot]

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

vkcom-publisher avatar Sep 25 '24 10:09 vkcom-publisher