VKUI icon indicating copy to clipboard operation
VKUI copied to clipboard

feat(Pagination): add caption property

Open inomdzhon opened this issue 1 year ago • 6 comments

  • close #6528

  • [x] Unit-тесты
  • [x] e2e-тесты
  • [ ] Дизайн-ревью
  • [x] Документация фичи

Описание

Добавляем возможность переключать отображение навигирования.

Создал для этого 3 новых пропса:

  • navigationButtonsStyle
  • prevButtonCaption
  • nextButtonCaption

Изменения

  • поправил текст для getPageLabel – "с" была латиницей (⚡ 36f2530f3fd12c43ae9804ed9e5bf377a0b0d188)

inomdzhon avatar Feb 26 '24 12:02 inomdzhon

size-limit report 📦

Path Size
JS 354.41 KB (+0.15% 🔺)
JS (gzip) 108.27 KB (+0.16% 🔺)
JS (brotli) 89.54 KB (+0.18% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.99 KB (0%)
CSS (gzip) 33.81 KB (0%)
CSS (brotli) 27.44 KB (0%)

github-actions[bot] avatar Feb 26 '24 12:02 github-actions[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Feb 26 '24 12:02 codesandbox-ci[bot]

e2e tests

Playwright Report

github-actions[bot] avatar Feb 26 '24 12:02 github-actions[bot]

👀 Docs deployed

Commit 8b4c37323d0f882838fca3c6922d9d631dc7ed67

github-actions[bot] avatar Feb 26 '24 12:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.58%. Comparing base (9f2d05c) to head (8b4c373). Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6630      +/-   ##
==========================================
+ Coverage   82.20%   82.58%   +0.37%     
==========================================
  Files         331      332       +1     
  Lines       10219    10494     +275     
  Branches     3422     3579     +157     
==========================================
+ Hits         8401     8666     +265     
- Misses       1818     1828      +10     
Flag Coverage Δ
unittests 82.58% <100.00%> (+0.37%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 12:02 codecov[bot]

@Fliqle нужон дизайн-ревью

Примеры в песочнице:

inomdzhon avatar Feb 26 '24 12:02 inomdzhon

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

vkcom-publisher avatar Mar 13 '24 10:03 vkcom-publisher