VKUI icon indicating copy to clipboard operation
VKUI copied to clipboard

chore: use css modules

Open BlackySoul opened this issue 2 years ago • 4 comments

  • resolve #3276

BlackySoul avatar Sep 15 '22 07:09 BlackySoul

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc2e014085d42855ad2bf66c4e98c43a979e6d47:

Sandbox Source
VKUI - default example Configuration

codesandbox-ci[bot] avatar Sep 15 '22 07:09 codesandbox-ci[bot]

size-limit report 📦

Path Size
JS 286.57 KB (+5.85% 🔺)
JS (gzip) 80.81 KB (+1.33% 🔺)
JS (brotli) 67.53 KB (+0.76% 🔺)
JS, unstable 27.9 KB (-0.48% 🔽)
CSS 244.08 KB (+0.08% 🔺)
CSS (gzip) 32.01 KB (+0.08% 🔺)
CSS (brotli) 26.03 KB (+0.13% 🔺)
CSS, unstable 602 B (0%)

github-actions[bot] avatar Sep 15 '22 07:09 github-actions[bot]

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/3289/

github-actions[bot] avatar Sep 15 '22 07:09 github-actions[bot]

Warnings
:warning:

8 changed screenshots found — review & update them via "Update Screenshots" action before merging.

Changed screenshots

actionsheet-ios-firefox-dark-w_2-1
actionsheet-ios-webkit-dark-w_2-1
contentcard-android-webkit-dark-1
header-android-webkit-dark-1
richcell-android-webkit-light-1
sizexconditionalrender-android-webkit-dark-1
sizeyconditionalrender-android-webkit-dark-1
sizeyconditionalrender-android-webkit-light-1

Code coverage

lines3757 / 487877.01%
statements3823 / 497276.89%
functions841 / 106978.67%
branches3430 / 477971.77%
branchesTrue0 / 0100.00%

Generated by :no_entry_sign: dangerJS against cc2e014085d42855ad2bf66c4e98c43a979e6d47

github-actions[bot] avatar Sep 15 '22 07:09 github-actions[bot]

[babel] [babel-plugin-transform-css-modules]: token key not found. See 'arrow' of /Users/d.suvorov/Documents/VKCOM/VKUI/src/components/Tooltip/Tooltip.tsx. [babel] [babel-plugin-transform-css-modules]: token key not found. See 'popper' of /Users/d.suvorov/Documents/VKCOM/VKUI/src/components/Tooltip/Tooltip.tsx.

При сборке ругается на переменные

А, usePopper() возвращает styles, из-за этого плагин думает, что это тот самый styles, который с импортом Tooltip.module.css))

✅ Сделал переименование styles от usePopper() в popperStyles

Спасибо 🙏

inomdzhon avatar Oct 05 '22 09:10 inomdzhon