ache
ache copied to clipboard
VIDA-NYU
Support Elasticsearch 7.x
You can manually create the index and import the index template but I don't think that is great for most people who aren't experienced with Elastic. I was trying to find the files that talk specifically about elastic to modify the index information. Can you point me to those so I can test a few things and build out the index/index template that will match with the Elastic 7.x data structures?
These are the files related the ES support:
- ElasticSearchRestTargetRepository.java (logic for dealing with indexes is here)
- ElasticSearchClientFactory.java
Currently, it checks if the index exists, and creates one if no index is found.
I believe the main thing that breaks compatibility support ES 7+ is the removal of document types, but I haven't had the time to try to fix it yet: https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html Maybe creating a new "repository" class to support ES 7+ would be the easiest. Anyway, please let us know if you manage to make it work. A PR for this would be very welcome.
I will absolutely let you know. With the document types being removed, it actually makes it much simpler to create index templates.
The easiest way to overcome this would be to configure the elastic instance for dynamic mapping. Then you are scalable unless they get rid of that functionality with I highly doubt.
I believe the main thing that breaks compatibility support ES 7+ is the removal of document types, but I haven't had the time to try to fix it yet: https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html Maybe creating a new "repository" class to support ES 7+ would be the easiest. Anyway, please let us know if you manage to make it work. A PR for this would be very welcome.
Hello, My Boss in office also try to correct this problem too. I already test with Elasticsearch 7.16.2 and It work. So I hope this can help, Thank you.
Great, thanks. Did you have the chance to test if the web search interface works as well?
Below this is the file which my boss edit for support ElasticSearch 7.x.
ElasticSearchRestTargetRepository.zip
I have made a pull request #282 and implemented some of the suggestions from @chanwitkepha. The indexing works great but the web search interface will not work without further changes.
