library
library copied to clipboard
VCVRack
Bark
Hi guys Looking to add my modules to the plugin manager
URL: https://github.com/Coirt/Bark License: BSD-4-Clause Minifest: https://github.com/Coirt/Bark/blob/0.6.3/Bark.json
Updated make file there. Hows this look?
RACK_DIR ?= ../..
SLUG = Bark
VERSION = 0.6.3
FLAGS +=
SOURCES += $(wildcard src/*.cpp)
DISTRIBUTABLES += $(wildcard LICENSE*) res
# Include the VCV Rack plugin Makefile framework
include $(RACK_DIR)/plugin.mk
manifest update: https://github.com/Coirt/Bark/blob/0.6.3/Bark.json
Same version just added a donate link
"donateUrl": "https://www.paypal.me/philgolden",
Just rediscovered a bug I thought I had fixed.
EDIT: Think I fixed it, so should be good to go as is.
Nah didn't fix it I have the trigger for the bug disabled, so as is!
Makefile is 0.6.4. Thought I defaulted master to 0.6.4 seems not the case.
https://github.com/Coirt/Bark/tree/0.6.4
The Makefile in the 0.6.4 tag is still at 0.6.3. I am using the HEAD of master.
Don't know what is going on with updating panels to github. I've updated the TrimLFO panel twice and the same panel (original upload) is still in the repo. Updated the One Band panel also the exact same way and the larger sized dev version updated fine.
Anyway... I will delete the Trim panel and upload a new panel to master. Will that change take effect or will it require a new version in order for clients to update?
There is a gradient on the panel which just requires deletion not sure if its significant enough for github to detect the change in the file.
@cschol Did I do something wrong the makefile everything seems correct in the make my end.
Do you want me to hook the build up to the 0.6.5 branch? Otherwise, you have to either create a tag for 0.6.5 or merge the 0.6.5 branch into master.
Not too sure what's going on could you take a look at the PR I made to see if there is actually conflicts, couldn't auto merge!
https://github.com/Coirt/Bark/pull/15
Generally it is not good to have branches and tags with the same name. They are ambiguous. 0.6.5 in this case.
I think you should get your version control straightened out first.
First, you have to delete the 0.6.5 tag:
git tag -d 0.6.5
Then you checkout the master branch and merge the 0.6.5 into master:
git checkout master
git merge 0.6.5
Now, you will encounter a conflict in changelog.txt. Open the file in your preferred editor and resolve the conflict.
Then add the file and continue the merge:
git add changelog.txt
git merge --continue
It should finish the merge cleanly now. It did for me. Then push up master to Github:
git push origin master
@cschol I see what you mean there. Taken under advisement! Thanks for the info.
Should I just increment the version in the json and post the commit hash for future updates?
I have one incoming with a small bugfix it is not worth creating a new branch for it.