Crash while file opening

[denmakesmusic]

essai1.zip Hi,

Rack crashes when it loads the attached file. I saved it and when I restarted Rack it loaded it at startup and crashed.

Windows 7/64.

[AndrewBelt]

It's 99.9% probably the Audio Interface. That module is not crash-proof yet, so just edit out the "deviceName" with a text editor and open it.

[denmakesmusic]

Actually, I think I posted the issue in the wrong project. It should be in Rack.

The deviceName is: "deviceName": "ASIO: ASIO PreSonus FireStudio (10 in, 6 out)",

Not sure what to do with that since another file that can be opened has the same deviceName.

[AndrewBelt]

Does clearing it or deleting the line make it openable?

[denmakesmusic]

I tried with "deviceName": "", or delete the line but still crashes

[AndrewBelt]

Oh, maybe it's the MIDI interface. Try removing the

"portName": "USB-MIDI 5",

line?

[denmakesmusic]

That's it. It can load without portName.

[AndrewBelt]

Pinging https://github.com/VCVRack/Rack/issues/238 and https://github.com/VCVRack/Rack/issues/239

[bontric]

I'm a bit confused as to why it crashes while loading the save file.

I can't see any problem with https://github.com/VCVRack/Rack/blob/master/src/core/MidiInterface.cpp#L57

@denmakesmusic Do you get any error message?

[AndrewBelt]

I'd imagine it's not the JSON parser that's failing but the selection/initialzation of the MIDI device

[bontric]

Oh yeah, of course you are right. Still a bit strange, since there are checks in place.

I can't reproduce this on Linux, might be another Windows specific thing. I'll try to reproduce this on Windows if I find the time but I'll focus on #231 since this might fix the issue here as well.

[denmakesmusic]

I made some other tests and if I start Rack alone, it works but if Reaper is also running (and using the USB MIDI interface), then Rack is crashing.

[AndrewBelt]

Is anyone able to just post a stack trace by running Rack through gdb or something?

[bontric]

This is without a doubt a duplicate of https://github.com/VCVRack/Rack/issues/223 and https://github.com/VCVRack/Rack/issues/238 . This is fixed in https://github.com/VCVRack/Rack/pull/231

@AndrewBelt Yeah.. Some will though, if you ask. Would be good to have some people on board who do proper testing and bug reports.

[AndrewBelt]

That could be arranged. There are a number of people who enjoyed trying the v0.4.0 features before it was released, so perhaps I could make it a recommendation to be familiar with gdb and give stack traces when appropriate. That's kind of what they did though, so not sure how to convince more people to do this.

[bontric]

Not that I have any experience with handling a quickly growing oss project like this, but here is what comes to my mind:

Spend some time on setting up an infrastructure for people who want to get involved. Major things would be:

• Make simple guides for people who want to help (make debug and typing bt is simple but sadly I know enough coders incapable of using a debugger properly)

• Ask for contributers via social media/on the GitHub repo( coders, testers, people taking care of sorting issues and maybe reviewers)

• For testing I'd say it'd be great to get at least one for each operating system (and maybe at some point version/distro). Additionally people with a large set of audio/midi equipment could be helpful.

• Communication for that team of contributers (chat or mailing list or something like that)

• maybe adding a section in rack, on the website or the readme naming contributers might be a motivation for some