TripoSR icon indicating copy to clipboard operation
TripoSR copied to clipboard

increase the Marching Cubes Resolution above 320

Open ezequielal39 opened this issue 11 months ago • 7 comments

Is it possible to increase the Marching Cubes Resolution above 320 by changing the variable "maximum = 320" in the file "gradio_app.py"? Or would it cause an error?

ezequielal39 avatar Mar 12 '24 00:03 ezequielal39

https://github.com/VAST-AI-Research/TripoSR/issues/44#issuecomment-1986916292

Yes. It appears that torchmcubes doesn't support resolutions higher than a certain limit.

pookiefoof avatar Mar 12 '24 05:03 pookiefoof

I fixed this, you can try #68

thatname avatar Mar 20 '24 18:03 thatname

@thatname impressive speedup! One thing I noticed, models have checker/square pattern which seems to be invariant to resolution or chunk size (arguments in the run.py). Do you know if it's due to something .cu file of marchingcubes? Or some hard-coded value.

I counted them and the value seems to be exactly 32 vertically.

image

IgorAherne avatar Mar 26 '24 05:03 IgorAherne

@thatname impressive speedup! One thing I noticed, models have checker/square pattern which seems to be invariant to resolution or chunk size (arguments in the run.py). Do you know if it's due to something .cu file of marchingcubes? Or some hard-coded value.

I counted them and the value seems to be exactly 32 vertically.

image

I think it's limited by the underlying triplane resolution, which is 64.

thatname avatar Apr 17 '24 04:04 thatname

@thatname impressive speedup! One thing I noticed, models have checker/square pattern which seems to be invariant to resolution or chunk size (arguments in the run.py). Do you know if it's due to something .cu file of marchingcubes? Or some hard-coded value. I counted them and the value seems to be exactly 32 vertically. image

I think it's limited by the underlying triplane resolution, which is 64.

Did you try different normal smoothing? Could help hide the janky marching cube faces.

image

See there better normal smoothing helps a lot

mrbid avatar Apr 20 '24 20:04 mrbid

@thatname impressive speedup! One thing I noticed, models have checker/square pattern which seems to be invariant to resolution or chunk size (arguments in the run.py). Do you know if it's due to something .cu file of marchingcubes? Or some hard-coded value. I counted them and the value seems to be exactly 32 vertically. image

I think it's limited by the underlying triplane resolution, which is 64.

Did you try different normal smoothing? Could help hide the janky marching cube faces.

image

See there better normal smoothing helps a lot @mrbid Can you give more details about normal smoothing, I am gonna do similar stuff. Which method do you use?

rozentill avatar May 13 '24 14:05 rozentill

@thatname impressive speedup! One thing I noticed, models have checker/square pattern which seems to be invariant to resolution or chunk size (arguments in the run.py). Do you know if it's due to something .cu file of marchingcubes? Or some hard-coded value. I counted them and the value seems to be exactly 32 vertically. image

I think it's limited by the underlying triplane resolution, which is 64.

Did you try different normal smoothing? Could help hide the janky marching cube faces. image See there better normal smoothing helps a lot @mrbid Can you give more details about normal smoothing, I am gonna do similar stuff. Which method do you use?

Yeah in Blender for example the more times you apply the smooth normals the smoother the normals become, you can apply it a few times it's basically like a gaussian blur on the vertex normals which dictate how light reflects off the faces.

https://github.com/VAST-AI-Research/TripoSR/assets/78346668/f15f629c-1ce9-4db1-94a0-c948fe27fbda

More information about showing vertex normals in Blender: https://www.katsbits.com/codex/show-normals/

mrbid avatar May 13 '24 21:05 mrbid