Algorithms icon indicating copy to clipboard operation
Algorithms copied to clipboard

add algorithms and data structures in any language

Open i-vishi opened this issue 5 years ago • 57 comments

Dated: Oct-07-2020 Regarding Delay in reviewing PR Hello, everyone, I am one of the maintainer of this repository. I know most of the PRs are the part of hacktoberfest and most of you are worried will your PRs will be eligible for Hacktoberfest 2020 or not. Since, all the maintainers are busy, it will take some time to review all the PRs. We have to review each PR and it may take some time. Also, the rules of Hacktoberfest have been changed to reduce spam PRs. There are many SPAM PRs with invalid code or no code. So, we have to review each PR one by one. Due to the changes in rules, the burden has been shifted to maintainers.

About adding and then removing hacktoberfest-accepted label, it was just to check and verify the eligibility of the label. Do not consider it as making your PR invalid.

All the PRs will be checked and reviewed

Thanks and Happy coding :computer: :man_technologist: :woman_technologist: :computer:

i-vishi avatar Oct 06 '18 21:10 i-vishi

Anyone can work on it. You only need to fork the repository and edit and then give a pull request. Just mention the issue in comment while giving Pull Request

i-vishi avatar Oct 06 '18 21:10 i-vishi

Like to Add Bucket sorting algorithm in C++

ananthuc73 avatar Oct 09 '18 07:10 ananthuc73

added doubly LinkedList in c. #699

Santan47 avatar Oct 28 '18 11:10 Santan47

I can provide the algorithm for singly and double linked list in c++ language @i-vishi

anmol20goyal avatar Oct 13 '19 11:10 anmol20goyal

Can i add Kahn's Algorithm for topological sort with proper documentation in this repo?

ankur-kayal avatar Oct 01 '20 05:10 ankur-kayal

Yes

On Thu, Oct 1, 2020, 11:20 AM Ankur Kayal [email protected] wrote:

Can i add Kahn's Algorithm for topological sort with proper documentation in this repo?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/VAR-solutions/Algorithms/issues/163#issuecomment-701902546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKOOZTZORHTEN6JMOJ4SO5DSIQKCHANCNFSM4FZOHK6Q .

anmol20goyal avatar Oct 01 '20 05:10 anmol20goyal

I would like to implement few standard problems of linked list. Can I go ahead?

nilam23 avatar Oct 01 '20 06:10 nilam23

Can you assign me this ?

ankur-kayal avatar Oct 01 '20 06:10 ankur-kayal

@ankur-kayal just give a PR for whatever algorithm you want to add, we will check and merge it

i-vishi avatar Oct 01 '20 06:10 i-vishi

@nilam23 Sure, go ahead and make sure you follow all the guidelines mentioned in README

i-vishi avatar Oct 01 '20 06:10 i-vishi

@i-vishi documentation needed? or do i only implement the algorithm?

ankur-kayal avatar Oct 01 '20 06:10 ankur-kayal

@ankur-kayal the code must be well-documented.

i-vishi avatar Oct 01 '20 06:10 i-vishi

@i-vishi noted!

ankur-kayal avatar Oct 01 '20 06:10 ankur-kayal

@i-vishi there has been some problems while cloning the repository. Please have a look at the screenshots below- NewCapture

Capture

nilam23 avatar Oct 01 '20 07:10 nilam23

Can i add sieve of eratosthenes algorithm in c++?

sakshi006 avatar Oct 01 '20 09:10 sakshi006

@nilam23 update your fork and then try to clone the repository

i-vishi avatar Oct 01 '20 09:10 i-vishi

@sakshi006 Sieve of eratosthenes is already implemented in C++, it is inside Mathematics directory.

i-vishi avatar Oct 01 '20 09:10 i-vishi

@i-vishi i am facing the same issue as @nilam23 when i cloned the repo.

ankur-kayal avatar Oct 01 '20 09:10 ankur-kayal

@ankur-kayal Can you provide the complete error message?

i-vishi avatar Oct 01 '20 09:10 i-vishi

it is the same as @nilam23 provided.

Cloning into 'Algorithms-1'...
remote: Enumerating objects: 40, done.
remote: Counting objects: 100% (40/40), done.
remote: Compressing objects: 100% (40/40), done.
Receiving objects: 100% (6970/6970), 3.41 MiB | 148.00 KiB/s, done. eceiving objects: 100% (6970/6970), 3.36 MiB | 122.00 KiB/s

Resolving deltas: 100% (2856/2856), done.
error: invalid path 'Divide and Conquer /closest_points.py'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

ankur-kayal avatar Oct 01 '20 10:10 ankur-kayal

@ankur-kayal @i-vishi Yes. There has been a problem with the Path Name associated with the Divide and Conquer file. If you can, kindly remove the trailing whitespaces (both left and right) from this directory name.

nilam23 avatar Oct 01 '20 10:10 nilam23

@ankur-kayal @nilam23 are you both using Windows OS? It works on Linux. Anyways, I have changed the name. Thank you for pointing out

i-vishi avatar Oct 01 '20 10:10 i-vishi

Yes, I am.

On Thu, 1 Oct 2020, 3:48 pm Vishal Gaur, [email protected] wrote:

@ankur-kayal https://github.com/ankur-kayal @nilam23 https://github.com/nilam23 are you both using Windows OS?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VAR-solutions/Algorithms/issues/163#issuecomment-702037631, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANVMQ3XPTDZ47ZXYMNNINMLSIRJPTANCNFSM4FZOHK6Q .

nilam23 avatar Oct 01 '20 10:10 nilam23

Do let me know if the problem persists

i-vishi avatar Oct 01 '20 10:10 i-vishi

@i-vishi i am working on windows too

ankur-kayal avatar Oct 01 '20 10:10 ankur-kayal

@i-vishi remove the right trailing whitespace, too. The problem still persists.

nilam23 avatar Oct 01 '20 10:10 nilam23

@i-vishi still the problem persists :(

Update: The issue has been resolved :) Thanks @i-vishi

ankur-kayal avatar Oct 01 '20 10:10 ankur-kayal

@nilam23 delete the old fork, make a new fork and clone that. It will be resolved

ankur-kayal avatar Oct 01 '20 10:10 ankur-kayal

@i-vishi @ankur-kayal Thanks both of you.

nilam23 avatar Oct 01 '20 10:10 nilam23

Adding Grid Unique paths (Possible number of ways to travel a grid from starting block to ending).Implementing in CPP and JAVA.

raj5036 avatar Oct 01 '20 13:10 raj5036