tmdb-java icon indicating copy to clipboard operation
tmdb-java copied to clipboard

Added ImdbId Endpoints on MovieService & Overloads to make language optional

Open ProIcons opened this issue 4 years ago • 4 comments

  • Added ImdbId to Endpoints so you can query a movie by it's imdb id.
  • Removed Language query parameter on Movie ExternalIds endpoint as is not a valid query option for this endpoint.
  • Added more Overloads to make Language query truly optional

ProIcons avatar Aug 22 '20 21:08 ProIcons

First of all thanks. Some remarks:

  • The API docs mention nothing about supporting IMDB IDs https://developers.themoviedb.org/3/movies/get-movie-details Where does the info come from that this is supported?
  • I'd rather not add too many new overloads. This is just a maintenance burden down the road. It's not that hard to e.g. just pass null for the language parameter.

UweTrottmann avatar Aug 27 '20 06:08 UweTrottmann

I've read this on the forum , it's undocumented You can try it thought it works. About the language as you see i didn't changed it everywhere, i just worked on the MovieService, and on the first endpoints of the PersonService. Which are the most important Services image

ProIcons avatar Aug 27 '20 09:08 ProIcons

I'd rather not support this. The docs also say to use find to look up external IDs. https://developers.themoviedb.org/3/getting-started/external-ids

i just worked on the MovieService, and on the first endpoints of the PersonService

How does this address my point about maintenance burden? If it's that much of an issue, I'd suggest switching to a builder pattern.

UweTrottmann avatar Aug 28 '20 09:08 UweTrottmann

It's up to you. Whatsoever it's working just fine and removing the need of an extraa query and potentially more Latency along the way on the user's app.

ProIcons avatar Aug 29 '20 10:08 ProIcons