SeriesGuide icon indicating copy to clipboard operation
SeriesGuide copied to clipboard

Compose

Open UweTrottmann opened this issue 2 years ago • 1 comments

Replace the About screen with a composable function.

  • https://developer.android.com/jetpack/compose/interop/interop-apis
  • https://github.com/android/compose-samples
  • Check how much app size changes.
    • From one dex file to two
    • Raw AAB file size 5,8 -> 7 MB
    • No native libraries added!
  • Pulls in Material 1.7.0, see #884 for issues with that.
  • This is tightly tied to a specific Kotlin version. If at any point the compose libraries are not longer updated, will be stuck at that Kotlin version.
  • [ ] Re-create edge-to-edge behavior.
    • Current state: not drawing behind nav bar, probably not offsetting for button bar in landscape.
    • Use "Modifier.safeDrawingPadding(), etc" source
    • https://developer.android.com/jetpack/compose/layouts/insets
  • [ ] Add scrollbars. Scrollbars are on the roadmap.
  • [x] Restore scroll behavior of app bar (TopAppBarDefaults does not seem to contain one that lifts up by color).
  • [ ] Create a duplicate theme for Compose, adapter is deprecated https://developer.android.com/jetpack/compose/designsystems/views-to-compose
    • Current state: need to check all colors match.

UweTrottmann avatar May 11 '22 14:05 UweTrottmann

Unit Test Results

12 files  ±0  12 suites  ±0   9s :stopwatch: ±0s 27 tests ±0  27 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7c7acf30. ± Comparison against base commit 2907aa60.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 11 '22 14:05 github-actions[bot]

Test Results

27 tests  ±0   27 :heavy_check_mark: ±0   16s :stopwatch: +6s 12 suites ±0     0 :zzz: ±0  12 files   ±0     0 :x: ±0 

Results for commit 7815cee7. ± Comparison against base commit d42e0f97.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 27 '22 09:10 github-actions[bot]