SeriesGuide
SeriesGuide copied to clipboard
UweTrottmann
Bug: new-episode notification appeared and/or not removed after I've marked an episode as watched
Describe the bug I've marked an episode as watched, and later got a notification of it.
To Reproduce
- Buy the app (SeriesGuide X), and enable notification of it, but after a whole day using the settings.
- Suppose you've visited the app before the notification, and marked an episode as watched.
Expected behavior Notification shouldn't appear, as I've already watched the episode.
Screenshots Sorry too late.
Smartphone (please complete the following information):
- Device: Pixel 4
- OS: Android 11
- Browser [e.g. stock browser, safari] Various, but why would that matter?
- Version [e.g. 22] "57", version code : 2105705.
Additional context ¯_(ツ)_/¯
Thanks, I'll look into this later. Currently busy with TMDB migration. As I just recently saw the code I don't think there is a bug: before a notification runs it queries for the episodes to show, explicitly including only not watched ones. Did you maybe use the Android feature to postpone notifications?
@UweTrottmann Perhaps I chose "watched" while it showed the notification, and the notification stayed?
@UweTrottmann I've tested now. If you get a notification, and instead of doing anything with it, you go to the app and mark it as watched, the notification doesn't go away. Need to test the original thing I reported too, but this is also a bug.
Thanks, this is currently by design. It would require some additional book-keeping of what notification is currently shown. To then clear it when one of the episodes is marked watched. Maybe if I have some time in the future...
@UweTrottmann Doesn't it have something extra in it, of the ID of the TV series and the episode, to go there? If the user has marked as watched, maybe you could iterate over the notifications of this kind, and find by this information, and cancel it?