Changing the device time zone breaks episode release times

[UweTrottmann]

Reported via email.

For US shows, release time in Upcoming/Recent is off for

• US Mountain (1 hour earlier)
• US Arizona (2 hours earlier)
• US Pacific (3 hours earlier) from the (correct) time displayed in the show list.

Notes:

• US Eastern and Central fine.
• Affects notifications as well, as the fault is in incorrect episode times.
• Cause likely in US handling (incorrectness is exactly equal to applied time shifts), though does not affect shows?
• Setting date back to January + re-adding shows time is correct

Cause:

• After changing the time zone, the stored episode release times are incorrect (as intended, decided to calculate them this way). However, the updater will only update episodes changed on TVDb or not older than a month >> Issues.

[UweTrottmann]

This is the currently intended behavior (US mainland offsets are baked into episode release times on storing).

Solutions:

• Lift updated on TVDB/or 1-month limit, so updater will update every episode. Will still require full update though.
• Handle US time zone offsets dynamically (like with user offsets). However, it only applies to US shows, making it impossible/hard to apply on database queries sorted by release time (e.g. for Upcoming/Recent).

[UweTrottmann]

This is the currently intended behavior (US mainland offsets are baked into episode release times on storing).

Solutions:

• Lift updated on TVDB/or 1-month limit, so updater will update every episode. Will still require full update though.
• Handle US time zone offsets dynamically (like with user offsets). However, it only applies to US shows, making it impossible/hard to apply on database queries sorted by release time (e.g. for Upcoming/Recent).

[simonsmiley]

I haven't looked at the code, but why don't you store the times in UTC and do all localization when actually showing it?

[simonsmiley]

I haven't looked at the code, but why don't you store the times in UTC and do all localization when actually showing it?

[UweTrottmann]

Did you read all of my previous comment?

[UweTrottmann]

Did you read all of my previous comment?

[UweTrottmann]

Since the switch to TMDB all episodes are updated when updating a show, making this much less of an issue.