Focusly icon indicating copy to clipboard operation
Focusly copied to clipboard

2 lofi's runs simultaniously

Open Abhishek7Tech opened this issue 2 years ago • 13 comments

Describe the bug 2 lofi's run simultaneously

To Reproduce Steps to reproduce the behavior:

  1. Go to 'main page'
  2. Click on 'any lofi'
  3. Click on 'another lofi'
  4. See error both lofi runs simultaneously

Expected behavior When one lofi is running and user clicks on another one "I think first one should pause automatically".

Screenshots If applicable, add screenshot(s) of the bug to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]

Additional context Add any other context about the problem here.

Abhishek7Tech avatar Feb 23 '23 13:02 Abhishek7Tech

hey @Abhishek7Tech thanks for opening this issue. Would you like to work on this issue? If yes then do share how you will be solving the issue.

Utkarshn10 avatar Feb 25 '23 10:02 Utkarshn10

Hi @Utkarshn10 I would like to but I am working on some other project so it may take some long time before I finish it out.

Abhishek7Tech avatar Feb 25 '23 11:02 Abhishek7Tech

No problem. Take your time.

Utkarshn10 avatar Feb 25 '23 11:02 Utkarshn10

@Utkarshn10 Hi I was reviewing the card component. Looks like it will need major changes to solve this issue.

Abhishek7Tech avatar Feb 26 '23 07:02 Abhishek7Tech

@Utkarshn10 Hi When 2 lofi's are run simultaneously looks like the time is running fast as well.

Abhishek7Tech avatar Feb 26 '23 07:02 Abhishek7Tech

@Utkarshn10 Hi I was reviewing the card component. Looks like it will need major changes to solve this issue.

Hey @Abhishek7Tech apologies for reaching out late. Yes card component might require some changes or we need to create a new card component for Lofi that only allows one run. Creating the new card component should also fix the timer issue.

Utkarshn10 avatar Mar 06 '23 15:03 Utkarshn10

HI @Utkarshn10 Apologies for replying so late, been busy with some work.

About the card component , I think we should start by adding a property like "playing: false" to each element and whenever user hits the play button the data should be updated and "playing: true" .

Abhishek7Tech avatar Apr 01 '23 05:04 Abhishek7Tech

Hey @Abhishek7Tech no need to be sorry. We all are here to collaborate and we are grateful to have you as a collaborator 😄

You can go ahead with the changes.

Utkarshn10 avatar Apr 01 '23 05:04 Utkarshn10

@Utkarshn10 It will take time unfortunately, been busy with a lot of work at present.

Abhishek7Tech avatar Apr 01 '23 12:04 Abhishek7Tech

No problem. Should I assign this to you ?

Utkarshn10 avatar Apr 02 '23 05:04 Utkarshn10

@Utkarshn10 NO I would like to pass this one.

Abhishek7Tech avatar Apr 02 '23 05:04 Abhishek7Tech

i want to work on this issue

asifMalik78 avatar Sep 24 '23 14:09 asifMalik78

Hey @asifMalik78 yeah sure. Issue assigned to you. Please go through the contribution guidelines mentioned in the README.

Utkarshn10 avatar Sep 24 '23 15:09 Utkarshn10