Webservice
Webservice copied to clipboard
Add after save callback
When an API returns a different result than the submitted data, we use "AfterSave" callback to catch this result
Tests needed for the new feature.
Where can I find the .sqlite file ?
What sqlite file? If you are referring to the test suite it uses an in memory sqlite db by default, no file.
Thank you for the information. I changed the URL of the sqlite file "webservice_test.sqlite" in the boostrap file with ":memory:" so that the tests start on Windows
@it-mob Admad meant you have to add testCase like these https://github.com/UseMuffin/Webservice/tree/master/tests/TestCase so that this helps to ensure that this change works well now and in future
@saeideng Yes sure. I'm working on it.
I added the tests but I don't understand the error of PHPSTAN during the CI tests
probably something that fixed in phpstan and now should not be this error in ignore list
you can remove this error from /phpstan.neon file
Thank you for the answer. I pushed my changes
Hello, Do you expect something else from me so that my PR can be validated ?
Sorry for the delay, I'll review the changes soon.
Thank you for the answer. I just realized that the callbacks beforeDelete/afterDelete were missing. I will add them and update my PR soon
Hello,
I just made a new commit with before & after delete callbacks but I have errors with Travis. I think the problem is the line break format (CRLF & CF) Can you help me solve this problem? (I work on Windows)
Thank you.
Hello, I wanted to know if you're still expecting something from me about that PR. I tried again to fix the PHPCS problem but without success. Thank you
Sorry, I had forgotten about this. NVM the phpcs issue. I can take care of it.
But I am now leaning towards targeting this enhancement to the cake-4.x branch (which is compatible with CakePHP 4) instead of master.