CraftGuide icon indicating copy to clipboard operation
CraftGuide copied to clipboard

made it runnable on 1.8.9, but still with bugs

Open Nymphet opened this issue 9 years ago • 3 comments

Hello,

i've been waiting for the 1.8 version of this mod since last month, but until now there are no public releases available, so i decided to build the mod from source. Since there's no build guide written for this mod, I built it with plain

./gradlew setupDecompWorkspace
./gradlew build

but numerous build errors popped out, so I made some quick fix to make it runnable on 1.8.9. however, i'm not sure if the build fails are caused by my local environment. Maybe we can add a build guide for this project just like the README of BuildCraft?

Some of the API calls seem to be outdated so I replaced them, since there are no tests written for this mod, i'm not sure if i broke something, please review my changes, thank you.

Cheers

Nymphet avatar Aug 02 '16 12:08 Nymphet

You'd just make a pr for mc 1.10.2.

liach avatar Aug 02 '16 13:08 liach

a built binary for quick tests

Nymphet avatar Aug 03 '16 06:08 Nymphet

I haven't looked at this yet, but certainly will as soon as I start looking into 1.8+ again.

Nonetheless, thanks for the contribution!

Uristqwerty avatar Aug 15 '16 18:08 Uristqwerty