tortilla icon indicating copy to clipboard operation
tortilla copied to clipboard

Show warning if file was not taken into an account in a specific diffStep

Open DAB0mB opened this issue 7 years ago • 3 comments

DAB0mB avatar Feb 27 '18 08:02 DAB0mB

@DAB0mB can you please explain and give an example?

dotansimha avatar Apr 17 '18 11:04 dotansimha

I think @darkbasic told me about it originally so I'm not sure. I think that if we specify a file in the template helper and it wasn't rendered because it doesn't exist or .gitignored we should print it to the console. Would be nice to have a color to it so it won't mix with the other logs. Sounds very useful actualy

DAB0mB avatar Apr 18 '18 03:04 DAB0mB

Yeah pretty close to it. In fact in order to reduce the number of commits and the subsequent rebase burden I'm trying to split each commit in multiple ones simply by specifying the files that I want to render:

{{{ diffStep "3.1" module="client" files="src/app/chats-lister/components/chat-item/chat-item.component.spec.ts" }}}

{{{ diffStep "3.1" module="client" files="src/app/services/chats.service.spec.ts" }}}

{{{ diffStep "3.1" module="client" files="src/app/chats-lister/containers/chats/chats.component.spec.ts" }}}

The issue with this approach is that if you add a new file during rebases and you forget about adding it to the files list, you won't get it rendered. Unfortunately it happens 100% of times. Something similar happened with the old Ionic tutorial, where I missed to render a whole step: I noticed only after people started complaining that the tutorial didn't work.

While rendering the views with tortilla manual render would be great to get a warning if something like that happens. Also I would love to have an ignore list, because for example I never render the package.json file: instead I simply type which packages the user needs to install and the related commands.

darkbasic avatar Apr 18 '18 08:04 darkbasic