graphql-scalars icon indicating copy to clipboard operation
graphql-scalars copied to clipboard

feat: add Cuid scalar #756

Open TillaTheHun0 opened this issue 2 years ago • 2 comments

Description

This PR implements a Cuid scalar as requested in #756. I also found myself wanting a Cuid scalar, so figured i'd try adding one here.

Related #756 Closes #756

Type of change

  • [x] New feature (non-breaking change which adds functionality)
  • [x] This change requires a documentation update

How Has This Been Tested?

Added unit tests for Cuid that test all available apis.

Test Environment:

  • OS: linux-gnu
  • GraphQL Scalars Version: 1.17.0
  • NodeJS: 16.15.1

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests and linter rules pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

TillaTheHun0 avatar Jun 23 '22 00:06 TillaTheHun0

@TillaTheHun0 is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 23 '22 00:06 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-scalars ❌ Failed (Inspect) Jun 23, 2022 at 0:24AM (UTC)

vercel[bot] avatar Jun 23 '22 00:06 vercel[bot]

Any eyes on this? Not sure why some of the checks are failing.

TillaTheHun0 avatar Aug 10 '22 13:08 TillaTheHun0

Looks good to me! Sorry for late review! @TillaTheHun0

ardatan avatar Aug 10 '22 16:08 ardatan

@ardatan no worries. Thank you!

TillaTheHun0 avatar Aug 10 '22 19:08 TillaTheHun0

/theguild newsletter

Urigo avatar Aug 11 '22 14:08 Urigo