graphql-modules icon indicating copy to clipboard operation
graphql-modules copied to clipboard

Update resolvers.ts, handle error when "resolver" variable in addObje…

Open DavisCacici opened this issue 11 months ago • 5 comments

I suggest this update to the addObject method: if the resolver is undefined, provide a clear message to the user.

This isn't a fix issue but a better way

DavisCacici avatar Feb 11 '25 14:02 DavisCacici

⚠️ No Changeset found

Latest commit: f1350946c3d1d9765f776c465df33685d959ce07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 11 '25 14:02 changeset-bot[bot]

Thanks for the PR! Could you add a changeset with "pnpm changeset" so we can bump the version with a proper changelog entry and could you also add a test to prevent future regression?

ardatan avatar Mar 07 '25 15:03 ardatan

Sure, I'll do it as soon as possible!

DavisCacici avatar Mar 17 '25 08:03 DavisCacici

Which test file should I add the test to?

DavisCacici avatar Apr 03 '25 16:04 DavisCacici

I add test in context.spec.ts, if you want I can move it

DavisCacici avatar Apr 08 '25 09:04 DavisCacici