fix: use hasOwnProperty function rather than built in one.

[justin-equi]

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Node does not expose prototype on the Module, so when a caller passes a direct module interface into the module it blows up. I believe this is the actual correct behaviour for the Module object. I ran into this issue with a vitest setup, but have since reproduced here using mjs imports.

Example

//module-test.mjs
export const Mutation = {
  sendMessage() {
    return true;
  },
};

And then the caller sets up the module as following

import { createModule, gql } from "graphql-modules";
import * as resolvers from "./module-test.mjs";
import { createApplication } from "graphql-modules";
const typeDefs = gql`
  type Mutation {
    sendMessage(message: String!): Message!
  }

  type Message {
    id: ID!
    body: String!
  }
`;
const mod = createModule({
  id: "test-module",
  typeDefs,
  resolvers,
});
const application = createApplication({
  modules: [mod],
});
console.log({ application });

Will fail with

TypeError: currentResolvers.hasOwnProperty is not a function
    at mergeResolvers (file:///.node_modules/graphql-modules/index.mjs:1694:34)
    at createResolvers (file://./node_modules/graphql-modules/index.mjs:1584:43)
    at Object.factory (file:///./node_modules/graphql-modules/index.mjs:1971:40)
    at file:///./node_modules/graphql-modules/index.mjs:1273:57

Fixes # 2476

Type of change

Please delete options that are not relevant.

• [ x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [ ] Test A
• [ ] Test B

Test Environment:

• OS:
• @graphql-modules/...:
• NodeJS:

Checklist:

• [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests and linter rules pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: cad0085e799a135a066ade7ede54963e146d76e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR