angular-blaze-template icon indicating copy to clipboard operation
angular-blaze-template copied to clipboard
verified publisher icon Urigo

Fix for Meteor 1.3

Open trajano opened this issue 9 years ago • 9 comments

Fixes https://github.com/Urigo/angular-blaze-template/issues/14

trajano avatar May 15 '16 05:05 trajano

@trajano does your fix works also with Meteor versions 1.2 and older? look also here: http://guide.meteor.com/1.3-migration.html#angular-meteor-packages

Urigo avatar May 15 '16 11:05 Urigo

No I changed it to be 1.3 only with all the imports and exports. Is there a way of packaging in Meteor so I can do

if (Meteor.versionAtLeast("1.3") { use mine} else { use existing? }

trajano avatar May 15 '16 18:05 trajano

yes, look at the link I've sent

Urigo avatar May 15 '16 18:05 Urigo

OK I'll add that part in, but would it still work with 1.2 is the question, I am using the pbastowski:angular-babel package

trajano avatar May 15 '16 19:05 trajano

@trajano have you tested it with both Meteor versions?

Urigo avatar May 17 '16 13:05 Urigo

No, I don't have Meteor 1.2 on my system anymore.

trajano avatar May 17 '16 14:05 trajano

it's easy to run from version, sorry, would need you to test that before I can merge

Urigo avatar May 17 '16 14:05 Urigo

NP would just need to find time to do it.

trajano avatar May 17 '16 14:05 trajano

Actually I have to remove that last commit, those changes added back "angular" to Meteor causing the #14 anyway.

trajano avatar May 17 '16 14:05 trajano