opencv4nodejs icon indicating copy to clipboard operation
opencv4nodejs copied to clipboard

Is this module working on Electron > v14?

Open stoefln opened this issue 3 years ago • 4 comments

Is this fork of opencv4nodejs context-aware by now? As stated in https://github.com/electron/electron/issues/18397, Electron is not going to support non context-aware modules anymore.

stoefln avatar Nov 28 '22 08:11 stoefln

Check these commit:

https://github.com/UrielCh/opencv-electron/commit/67d83d0217f38f7d279779e6246bb503ad5700f0

by https://github.com/zcmgyu

UrielCh avatar Nov 28 '22 21:11 UrielCh

Interesting. Looks like it's working then. I still wonder if this has been properly tested with electron. If you read "What does this look like for Native Module X?" in https://github.com/electron/electron/issues/18397, it seems that there are some code changes needed. Like in there example: https://github.com/CharlieHess/node-mac-notifier/pull/32/files

I can't find "NAN_MODULE_WORKER_ENABLED" anywhere in your repo. 🤔

stoefln avatar Nov 29 '22 10:11 stoefln

Can try the forked: https://github.com/liuxiaoxinxin/npm-opencv-build Specifically, process.env.OPENCV_BIN_DIR is allowed to be set externally to support Electron's different development environment directories and production environment directories

liuxiaoxinxin avatar Mar 30 '23 02:03 liuxiaoxinxin