bull_exporter icon indicating copy to clipboard operation
bull_exporter copied to clipboard

Add options to pass redisPassword

Open AnthonyDurussel opened this issue 3 years ago • 6 comments

Description

This is a

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Documentation
  • [ ] Other

Checklists

Commit style

  • [ ] Changes are on a branch with a descriptive name eg. fix/missing-queue, docs/setup-guide

  • [ ] Commits start with one of feat: fix: docs: chore: or similar

  • [ ] No excessive commits, eg: there should be no fix: commits for bugs that existed only on the PR branch (see guide-to-interactive-rebasing)

Protected files

The following files should not change unless they are directly a part of your change.

  • [ ] yarn.lock (unless package.json is also modified, then only the new/updated package should be changed here)

  • [ ] package.json (renovate bot should handle all routine updates)

  • [ ] package-lock.json (Should not exist as this project uses yarn)

  • [ ] tsconfig.json (only make it stricter, making it more lenient requires more discussion)

  • [ ] tslint.json (only make it stricter, making it more lenient requires more discussion)

AnthonyDurussel avatar Sep 15 '21 07:09 AnthonyDurussel

Hello,

I try to use your exporter with a Redis cluster that had a password with special characters.

Take as example : password = suds*$d@?2\

because of these characters, I was not able to connect the IoRedis. Even in using url encode.

So I develop a PR to allow passing Redis Password as an options

AnthonyDurussel avatar Sep 15 '21 07:09 AnthonyDurussel

This can be added to the URL infront of the host, instead of requiring a separate env variable.

autarchprinceps avatar May 30 '22 12:05 autarchprinceps

But if you have any special characters in the password, you cannot add it to the URL. Even if you use url encode.

AnthonyDurussel avatar May 30 '22 12:05 AnthonyDurussel

Other than special characters, having a separate environnement variable for password allows to retrieve it from a secret if you use this image in kubernetes

maxaggedon avatar Sep 22 '22 08:09 maxaggedon

hi @maxaggedon I fixed the log the password. Can you merge this PR in the next release ?

AnthonyDurussel avatar Aug 16 '23 10:08 AnthonyDurussel

@AnthonyDurussel I reported a potential security issue because I saw it, but I don't have write access on this repo, sorry.

maxaggedon avatar Aug 16 '23 13:08 maxaggedon