clsql icon indicating copy to clipboard operation
clsql copied to clipboard

Symbol construction fix.

Open nzioki opened this issue 8 years ago • 3 comments

Symbol is INTERN'ed in lower case when print-case is :downcase and oodml.lisp fails to compile.

nzioki avatar Dec 26 '16 15:12 nzioki

This looks mostly good, though I am curious about your changes to the package files.

I also dont understand the change from the :export clause of the defpackage to the (export) fn call with interned symbols - or why this was desirable or necessary? If it was desirable or necessary, why was it not done to all packages

bobbysmith007 avatar Jan 16 '17 20:01 bobbysmith007

Actually did not intend to include the package export changes into the pull request.

The reason for the selective modification (ODBC and DECIMAL packages) is that I have other packages in the same image with the same name thus resulting in a conflict. (Different symbols exported.)

On 16/01/2017 23:15, Russ Tyndall wrote:

This looks mostly good, though I am curious about your changes to the package files.

I also dont understand the change from the :export clause of the defpackage to the (export) fn call with interned symbols - or why this was desirable or necessary? If it was desirable or necessary, why was it not done to all packages

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UnwashedMeme/clsql/pull/8#issuecomment-272952853, or mute the thread https://github.com/notifications/unsubscribe-auth/AA91xsYQzBF9R2ZH9Z5lcE5zok6-RFU3ks5rS8_RgaJpZM4LV0BI.

nzioki avatar Jan 16 '17 22:01 nzioki

Sorry that I spaced on this for a year. Do you happen to remember what was wrong with the format variant vs the concatenate variant?

I can see certain printer settings affecting the format.

I am finally getting around to working on this again, so I am trying to integrate the important changes

bobbysmith007 avatar Feb 09 '18 22:02 bobbysmith007