Linux: Add “RunWithoutUpdate” and “Update” actions to the XDG desktop file

[illwieckz]

Add “RunWithoutUpdate” and “Update” actions to the XDG desktop file:

• The “RunWithoutUpdate” action runs the engine without checking for any updates.
• The “Update” action force the display of the game downloader, like when clicking on the gear icon on the splash.

Extracted from:

• https://github.com/Unvanquished/updater/pull/142

[illwieckz]

On my end it works (GNOME).

[slipher]

"Run" sounds like it should be the normal default behavior, but it is a specialized option for skipping updates.

[illwieckz]

Renamed to RunWithoutUpdate, this is just an internal symbol though (not visible to the user).

[slipher]

The RunWithoutUpdate action looks OK in terms of functioning correctly.

I have doubts about the Update action. I believe this would cause the check for an updater update to be skipped. Then the update might not work correctly if the download format has changed.

The comment about RelaunchCommand in splashcontroller.h should be updated.

[illwieckz]

Maybe we need an update command that first runs updateupdater then updategame.

[slipher]

Maybe the Update action could be described as something like "Modify or repair installation". When there is really an update it should happen automatically (barring slow DNS/connection), so it might be used more for the other purposes. The update process can also be understood as repairing the installation if it is a version you have already downloaded.

[illwieckz]

I just thought that such feature to force the check for an update (either updater, either game, either both) and offering it to the user would be useful if one day we implement an option to “not phone home”:

• https://github.com/Unvanquished/updater/issues/82

So even if implementing the “update everything” feature doesn't require to implement the “do not phone home” feature, the two features interact together so we may design the first one in a way it will be compatible with the second one with minimal changes.