Unvanquished icon indicating copy to clipboard operation
Unvanquished copied to clipboard

sgame: Send pmove_params on ClientBegin

Open DolceTriade opened this issue 3 years ago • 3 comments

Before they were being sent on ClientConnect. This is bad because the client doesn't actually process server commands at this time, so they get queued. They get queued with other potentially stale commands, so we don't want to carry them forward to the next game. Moving pmove_params here allows us to drop early commands which can load to bugs like the stuck scoreboard in #1102

DolceTriade avatar Sep 16 '22 07:09 DolceTriade

I'd prefer to ask @slipher on that topic, and/or to run some tests with a highly laggy server which quickly (faster than the client can go in game, possibly because UDP downloading) changes maps before accepting this.

ghost avatar Sep 18 '22 17:09 ghost

Well, this change is 100% safe. Keep in mind that in its current state, pmove_params is sent before any instructions for downloading missing paks, which seems wrong.

DolceTriade avatar Sep 18 '22 20:09 DolceTriade

What I keep in mind is that I do not know enough about how this works. Can't say if good or bad.

ghost avatar Sep 18 '22 20:09 ghost

ping

ghost avatar Apr 04 '23 22:04 ghost

I think we found some bugs with this approach.

DolceTriade avatar Apr 04 '23 23:04 DolceTriade

Yeah there was some PR on another repository which goes together with this change and I described a problem with the approach there

slipher avatar Apr 04 '23 23:04 slipher