Unvanquished
Unvanquished copied to clipboard
sgame: Send pmove_params on ClientBegin
Before they were being sent on ClientConnect. This is bad because the client doesn't actually process server commands at this time, so they get queued. They get queued with other potentially stale commands, so we don't want to carry them forward to the next game. Moving pmove_params here allows us to drop early commands which can load to bugs like the stuck scoreboard in #1102
I'd prefer to ask @slipher on that topic, and/or to run some tests with a highly laggy server which quickly (faster than the client can go in game, possibly because UDP downloading) changes maps before accepting this.
Well, this change is 100% safe. Keep in mind that in its current state, pmove_params is sent before any instructions for downloading missing paks, which seems wrong.
What I keep in mind is that I do not know enough about how this works. Can't say if good or bad.
ping
I think we found some bugs with this approach.
Yeah there was some PR on another repository which goes together with this change and I described a problem with the approach there