git_training icon indicating copy to clipboard operation
git_training copied to clipboard

Handle translations

Open joapuiib opened this issue 3 years ago • 1 comments

Hi, I love this Git tutorial and I'm currently translating it to Catalan in my fork: https://github.com/joapuiib/git_training/tree/master/translations/ca

I've created a folder named translations where a folder can be created for each language this tutorial is translated to. I don't know if this is the best approach. I'd like to hear from you and know if you think this is a good idea.

For now, I've been working on the master branch, but I've seen that tutorial_wip exists In order to not make the history "dirty". I could make the branch translation_catalan and then, merge it to master, but there would be a visible commit that would spoil the history if a lot of translations are being made.

Do you want to integrate translations and, if so, how would be the best way to add these changes?

joapuiib avatar Oct 17 '22 10:10 joapuiib

Hi @joapuiib sorry for the late reply, I've missed this!

This is great work! I think adding a translations folder is fine, past contributions have already broken the idea to have a clear history of the main branch as part of the tutorial. 1000% better to have contributions :)

I'd be very happy if you open a PR adding your translation! In terms of commits I'd just merge that as one commit saying something like "Add Catalan translation by @joapuiib"

UnseenWizzard avatar Oct 30 '22 16:10 UnseenWizzard