cocoapods-amimono icon indicating copy to clipboard operation
cocoapods-amimono copied to clipboard

[Enhancements] Currently Amimono rejects Test Targets would like to reject other projects for more complex workspaces.

Open bainfu opened this issue 8 years ago • 1 comments

For the patch public method, it would be nice to supply the criteria to reject or only allow specific aggregate targets for more complex workspaces.

bainfu avatar Mar 10 '17 21:03 bainfu

Thanks for suggesting this. I couldn't really find a good way to implement something like this, because this plugin requires to do changes to the user project after it has been written to disk. This is more or less the order things happen when you run pod install, there are many more things that happen of course, but I'll be mentioning the ones relevant to this plugin:

  1. Podfile post install hooks is executed executed from here.
  2. User project is modified executed from here.
  3. Plugin post install hook is executed from here.

Ideally the criteria to reject targets could be supplied in here, but that's the first event from the list described above, which is too early.

There is an API to pass options to plugins, and the plugin information is stored in the installer so implementing something like this should be straightforward.

I'm happy to receive a PR if you're interested in implementing and having such thing.

UnsafePointer avatar Apr 09 '17 18:04 UnsafePointer