next-right-now icon indicating copy to clipboard operation
next-right-now copied to clipboard

Add prettier (from #59)

Open Vadorequest opened this issue 4 years ago • 15 comments

WIP

Waiting on https://github.com/prettier/prettier/pull/6644 to be merged

Big discussion on https://github.com/prettier/prettier/issues/8507 about Prettier's mindset and goals

See:

  • https://github.com/prettier/prettier-vscode/issues/352
  • https://github.com/prettier/prettier-eslint-cli/issues/272

Vadorequest avatar May 31 '20 15:05 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit 64fc674377c3e80e5be4880936562c9df9745b5f successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-nyuq3nt9g.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar May 31 '20 15:05 Vadorequest

[GitHub Actions] E2E tests SUCCESS

Vadorequest avatar May 31 '20 15:05 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit 8e4c39cbbaa83dc5e12cf90bddcffa4e68afbd31 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-cujrhrrbc.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar May 31 '20 15:05 Vadorequest

@samuelcastro I've made some more attempts and wasted a few more hours on this.

Overall, Prettier makes code look worse than before, their non-configurable opinionated choices aren't for me.

Do you know of any alternative? Couldn't eslint do some of it, maybe?

Vadorequest avatar May 31 '20 16:05 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit f0a2e21324af1b64cec102a6892bb6bc9531dc26 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-g9ta5k38v.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar May 31 '20 16:05 Vadorequest

https://www.reddit.com/r/javascript/comments/8as6ns/i_dont_like_prettier/

Nobody loves what prettier does to their syntax

Everyone loves what prettier does to their coworkers' syntax

🤣

Vadorequest avatar May 31 '20 16:05 Vadorequest

https://github.com/prettier/prettier-eslint may likely be the best alternative, it's basically a customisable prettier through eslint rules.

Vadorequest avatar May 31 '20 16:05 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit a1a9676fd2d3cadaa250948fb194ffcedac5041a successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-l5jev0oz8.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar May 31 '20 19:05 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit 6c758a0339c551a9c379ca60bfddd3fcd256a8d5 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-pxt4h1y79.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar Jun 02 '20 08:06 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit 408c622ad0c8fd6e48835716f64a3db976018517 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-km78d3trv.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar Jun 02 '20 10:06 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit 757861122985b3f3b556c42fdccb134159a68dbc successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-qgw82l00w.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar Jun 02 '20 11:06 Vadorequest

@samuelcastro I've made some more attempts and wasted a few more hours on this.

Overall, Prettier makes code look worse than before, their non-configurable opinionated choices aren't for me.

Do you know of any alternative? Couldn't eslint do some of it, maybe?

I don't have any other alternative, we could stick with just eslint for now.

samuelcastro avatar Jun 02 '20 20:06 samuelcastro

I've tried a lot with prettier, and I'm not satisfied with the job it does. While it surely helps on some part of the code, it also makes other parts less readable/maintainable.

We'll stick to eslint for now, I hope it evolves in the right direction, or a proper alternative is made available.

Vadorequest avatar Jun 02 '20 21:06 Vadorequest

[GitHub Actions] Deployment SUCCESS Commit c8af6401b0a2403ad3de161ded629b112e7543d0 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-qgw82l00w.now.sh Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

Vadorequest avatar Jun 10 '20 10:06 Vadorequest

FYI I'm following https://github.com/romefrontend/rome new features and hope it'll eventually be able to replace Prettier/EsLint.

Vadorequest avatar Sep 17 '20 12:09 Vadorequest