unleash icon indicating copy to clipboard operation
unleash copied to clipboard

fix: replace connect-session-knex with something

Open ivarconr opened this issue 4 years ago • 2 comments

connect-session-knex does not handle errors and their are not handled in an async context. We should consider forking or finding a better alternative for this library.

ivarconr avatar Sep 20 '21 10:09 ivarconr

https://github.com/Unleash/unleash/pull/875

ivarconr avatar Sep 20 '21 10:09 ivarconr

Just reading through issues and thinking of starting to contribute as I find this to be a cool project...

Went down the rabbit hole and looks like connect-session-knex has resolved the error handling on db connect with a PR, so this should be fine? https://github.com/gx0r/connect-session-knex/commit/0b580674765a2de745200d84734c8695a888c984

tn819 avatar Aug 09 '22 09:08 tn819

Was fixed in v3.0.0 of connect-sesion-knex

ivarconr avatar Aug 25 '23 20:08 ivarconr