MCGalaxy icon indicating copy to clipboard operation
MCGalaxy copied to clipboard

/Museum and /restore should use historic blockdefs

Open rdebath opened this issue 2 years ago • 5 comments

Museum will load the block definitions of the current version of the level. For correct rendition it should use the blocks defined in the saved files.

Mitigation: Blockdefs are usually only added to so the current version is normally sufficient.

rdebath avatar Nov 03 '21 05:11 rdebath

Probably should also load the other backed up files too (e.g. level properties), as that was one of original motivations behind adding backups of the metadata files too

UnknownShadow200 avatar Nov 04 '21 12:11 UnknownShadow200

Like /museum the command /restore doesn't seem to know about files other than the basic block array.

PS: Looks like /RestoreSelection can replicate what /restore currently does by using /ma.

rdebath avatar Apr 06 '23 11:04 rdebath

I know this is an XKCD "workflow" moment, but if /restore is implemented to restore blockdefs, bots, etc, then there needs to be an option to restore only blocks like it used to.

Goodlyay avatar Apr 06 '23 12:04 Goodlyay

:grin: I noticed and added a "PS".

The /RestoreSelection is basically identical if you choose the blocks using /ma. The differences being that it honours the draw limit and actually saves the restoration into the blockdb so you get a nice history.

I suppose a /RestoreBlocks alias for this might be nice.

rdebath avatar Apr 06 '23 12:04 rdebath

I didn't catch that. Seems like it would work

Goodlyay avatar Apr 06 '23 12:04 Goodlyay