Web client issues

[UnknownShadow200]

• [ ] Escape sometimes requires pressing it twice, or doesn't rehide cursor properly.
• Chrome, Edge and Firefox all slightly different issues. Need to fix on all 3.
• Firefox shows: Request for pointer lock was denied because Element.requestPointerLock() was not called from inside a short running user-generated event handler, and the document is not in full screen
• [ ] Ask to confirm before closing the game Particularly to prevent pressing Ctrl + W automatically closing the game
• [x] Some ctrl/alt keypresses aren't intercepted For example Ctrl + S to save the page. (Ctrl + W is a different issue)
• [x] Paste from system doesn't work Need to hook into the javascript paste event. Need to rethink how pastes are handled in general, since the paste event is delivered after key press event is handled.
• [x] Rendering is completely broken on safari Breaks the game on mac and ios
• [ ] Skin changes don't show up instantly. Caused by two factors:
• ~only static.classicube.net/skins/ and classicube.net/skins/ are flushed when skin changes, classicube.net/static/skins isn't. But the web client uses classicube.net/static/skins (fixed)~
• the browser will return results from disk cache
• [ ] Holding WASD doesn't work on android. Need to investigate. Is android immediately raising a keyup and not repeating keydown?
• [ ] Can't hold down keys to repeat text on android. Probably same issue as WASD.
• [ ] Need a way to right click to place on android. Maybe double tap to delete?
• [x] Can't drag finger to move camera around. Need to look into emscripten_touch_start
• [x] Issues with alpha and low fog Zones, shadows, rain seem to stuff up.
• [ ] Issues with indexeddb getting reset on firefox github.com/emscripten-core/emscripten/ issues/6499
• [ ] Use web worker for generating singleplayer map
• [x] Texture pack download dialog always shows 'Determining..' need to patch emscripten to set fetch->total in xhr.onload, like it does in xhr.onprogress
• [x] Mouse wheel doesn't work
• Chrome shows: [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/6662647093133312
• need to patch wheel event handler to add { usePassive: true }
• [ ] Properly handle WebGL context lost/restored
• [ ] Need to show a message for Opera telling them to disable Mouse Gestures
• [ ] Backspace doesn't work properly with chat input on iPhone

[Fixer-007]

Some keypresses aren't intercepted

Pressing Ctrl + W closes tab instead of moving forward..

Yeah, noticed that, any movement while holding Ctrl is dangerous... ctrl+a - selects all, ctrl + w closes tab, etc. I hope all game hotkeys can be intercepted properly (Latest Firefox on w7).

P.S. Nice job for web client! This is huge! :)

[UnknownShadow200]

From prior testing I could intercept ctrl+s and some others, but can't completely intercept ctrl+w. I can only popup a dialog confirming if user wants to quit (which should probably be done anyways) On Jun 5, 2019 9:57 AM, "Fixer" [email protected] wrote:

Some keypresses aren't intercepted

Pressing Ctrl + W closes tab instead of moving forward..

Yeah, noticed that, any with Ctrl is too dangerous, ctrl+a - selects all, ctrl + w closes tab, etc. I hope all game hotkeys can be intercepted properly.

P.S. Nice job for web client! This is huge!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UnknownShadow200/ClassiCube/issues/588?email_source=notifications&email_token=ABRVGJFVCE54MHLNBE4HXBDPY36OXA5CNFSM4HPWUWRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6GMTY#issuecomment-498886223, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRVGJB3YU45APYG6RPF2HLPY36OXANCNFSM4HPWUWRA .