NoiseModelling icon indicating copy to clipboard operation
NoiseModelling copied to clipboard

Activating "computeLAEQOnly" results in an error

Open sachabaclet opened this issue 2 years ago • 3 comments

NoiseModelling version 3.4.4

Describe the bug When I run the WPS script "Noise_level_from_source" with an added line to activate the option "computeLAEQOnly", the script throws an error towards the end of its execution because it attempts to create an LDAY_GEOM table from columns that don't exist.

To Reproduce Add these lines to the Noise_level_from_source script:

boolean computeLAEQOnly = true;
ldenConfig.setComputeLAEQOnly(computeLAEQOnly);

And run the script.

Geoserver log geoserver.log

sachabaclet avatar May 30 '22 14:05 sachabaclet

Hi,

Your modifications of the script is not complete, you don't have to copy non existing fields on the same script. You have to do additional modifications line 293 (no adding HZ fields in the query)

nicolas-f avatar May 31 '22 07:05 nicolas-f

Hi Nicolas, Thanks for the clarification. I have made the changes that you suggested and it now works. For better ease of use, would it be possible to automate these modifications in the next version of NoiseModelling by checking the value of computeLEAQOnly (in ldenConfig) before adding the LEQ and HZ columns? And possibly add a "computeLAEQOnly" input to the groovy script? I have done it, and can upload the script if you'd like.

sachabaclet avatar May 31 '22 15:05 sachabaclet

Hi,

Thank you for the proposal, we will discuss between us to know if it is useful to add a new parameter knowing that there are already quite a few currently...

nicolas-f avatar Jun 01 '22 09:06 nicolas-f