NoiseModelling icon indicating copy to clipboard operation
NoiseModelling copied to clipboard

The table BULIDINGS does not have an associated SRID.

Open pierromond opened this issue 4 years ago • 3 comments

NoiseModelling version 3.3.1

Describe the bug

I get this error with "Noise_level_from_source". But BUILDINGS does have a associated SRID. Process failed during execution javax.script.ScriptException: java.lang.IllegalArgumentException: Error : The table BULIDINGS does not have an associated SRID. java.lang.IllegalArgumentException: Error : The table BULIDINGS does not have an associated SRID. Error : The table BULIDINGS does not have an associated SRID.

pierromond avatar Dec 02 '20 09:12 pierromond

The user get an error on the srid even if table not exists. We should first check if table not exist, and then check if it has srid.

pierromond avatar Dec 02 '20 09:12 pierromond

We should also check if Building table as an height field and send error if not.

pierromond avatar Dec 02 '20 09:12 pierromond

Dear @pierromond We have developed this kind of check here https://github.com/orbisgis/geoclimate/blob/master/osm/src/main/groovy/org/orbisgis/orbisprocess/geoclimate/osm/OSMGISLayers.groovy#L171 It's a process that extract GIS layers from a OSM xml file. Building table is then formatted to have a height value : https://github.com/orbisgis/geoclimate/blob/master/osm/src/main/groovy/org/orbisgis/orbisprocess/geoclimate/osm/FormattingForAbstractModel.groovy#L36

We use two methods.

  • A naive one that apply a match between the building type and a level. We use json file to define that : https://github.com/orbisgis/geoclimate/blob/master/osm/src/main/resources/org/orbisgis/orbisprocess/geoclimate/osm/buildingParams.json#L16
  • Or a RandomForest model that set a heigth according some properties of the building . It is longer because it calculates morphological indicators but the results are better.

ebocher avatar Dec 02 '20 10:12 ebocher