universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Fix proposal for #929

Open nicolasfranck opened this issue 11 months ago • 4 comments

Description of what you did:

  • This is a fix proposal for #929 were I introduce a cache key in the content-left-panel that is only changed after a login event. This should be added to the thumbnail uri. Not sure if this works with all urls as I merely append ?t=<timestamp> to the thumbnail uri, and I know that some people use query parameters in their iiif image api url's (because directly passed to an iipsrv). e.g. https://myhost/?IIIF=<IIIF>?t=timestamp

nicolasfranck avatar Mar 19 '24 13:03 nicolasfranck

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Mar 19 '24 13:03 codesandbox[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 6:23pm

vercel[bot] avatar Mar 19 '24 13:03 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Mar 19 '24 13:03 codesandbox-ci[bot]

Thanks, @nicolasfranck! I think the questions we now need to answer (which might require input from others) are whether there are other situations where we should invalidate the cache, and whether this replaces the existing config setting, or if it should perhaps be incorporated with it (e.g. if the thumbnail cache invalidation setting is disabled, should that prevent us from adding the extra parameter to thumbs?).

demiankatz avatar Mar 21 '24 12:03 demiankatz