universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Configuration and manifest do not load when using a js build tool

Open hackartisan opened this issue 1 year ago • 1 comments

UV version: 4.0.23 and above

I'm submitting a:

  • [x] bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below
  • [ ] feature request => please use the user stories repo
  • [ ] support request => Please do not submit support requests here, use stackoverflow

Current behavior: Config cannot load when using a js build tool

Expected behavior: Config should still be able to load

Steps to reproduce:

Here's a codesandbox replicating the error, based on the vite example, all we did was increment the UV version in the package.json:

https://codesandbox.io/p/sandbox/uv-vite-multiple-example-forked-yv9ryr Related code: The error was introduced in this PR -- it appears that the relative path navigation in loadconfig works fine when fetching the release from a cdn but not when js is loaded through a build tool like vite. Other build tools (webpack, etc) would probably also not work.

Other information:

hackartisan avatar Jan 25 '24 17:01 hackartisan

Also, it would be good to add the vite example to the build process for new PRs.

The uv-nextjs-example PR introducing this error also shows the bug.

hackartisan avatar Jan 25 '24 17:01 hackartisan