UV4 - Timecode links in More Information panel broken?

[adamtovell]

UV version:

 [email protected]

I'm submitting a:

• [x ] bug report
• [ ] feature request => please use the user stories repo
• [ ] support request => Please do not submit support requests here, use stackoverflow

Current behavior: Hyperlinks are no longer appearing as links:

vs

Expected behavior: The timecode values should appear as hyperlinks

Steps to reproduce:

Related code:

// insert any relevant code here

Other information:

[stephenwf]

Do they still work if you click on them? Also @adamtovell can you remind me why we didn't make them links in the metadata? Something like:

<a href="#t=123.45">[00:02:03]</a>

[adamtovell]

@stephenwf no, they're not clickable anymore - just appearing as text.

Don't think I was involved in spec'ing how they should appear in the json, but this is what they look like atm:

          "label" : {
            "en" : ["Summary"]
          },
          "value" : {
            "en" : ["<span>Part 1 [Tape 1 (F2499) Side A] <span data-uv-navigate='#?t=0'>[00:00:00]</span>: Nina Jenkins (NJ) born in 1946, in East London, then moved to Essex. Mother: legal secretary; father: Education Officer. Catholic education; post-war London; move to Cardiff: Welsh roots. Her crush on hockey captain.</span>", "<span>Part 2 [Tape 1 (F2499) Side B] <span data-uv-navigate='#?t=1832'>[00:30:32]

[stephenwf]

Fixed by #854

[edsilv]

Can we close this?

[adamtovell]

Reckon we can, yep

From: Edward Silverton @.> Sent: 31 August 2022 09:39 To: UniversalViewer/universalviewer @.> Cc: Tovell, Adam @.>; Mention @.> Subject: Re: [UniversalViewer/universalviewer] UV4 - Timecode links in More Information panel broken? (Issue #849)

Can we close this?

Reply to this email directly, view it on GitHubhttps://gbr01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUniversalViewer%2Funiversalviewer%2Fissues%2F849%23issuecomment-1232641781&data=05%7C01%7C%7Cad1a3e14c56045373ea008da8b2c4c80%7C21a44cb7f9c34f009afabd1e8e88bcd9%7C0%7C0%7C637975319623231879%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=imZptsiVPTgLXbsgbzW8FglsrzyzeXxvNqwxUrSRNoA%3D&reserved=0, or unsubscribehttps://gbr01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAGOZFJX3KH4TJ3XHRJMEXTV34K3PANCNFSM5TKB4NYQ&data=05%7C01%7C%7Cad1a3e14c56045373ea008da8b2c4c80%7C21a44cb7f9c34f009afabd1e8e88bcd9%7C0%7C0%7C637975319623231879%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FOc0ZoqzWUNXRxleyEo5RlMnRz%2BwKDqleH38MlyRaZw%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.@.>>

---

Experience the British Library online at www.bl.ukhttp://www.bl.uk/ The British Library's latest Annual Report and Accounts : www.bl.uk/aboutus/annrep/index.htmlhttp://www.bl.uk/aboutus/annrep/index.html Help the British Library conserve the world's knowledge. Adopt a Book. www.bl.uk/adoptabookhttp://www.bl.uk/adoptabook The Library's St Pancras site is WiFi - enabled

---

The information contained in this e-mail is confidential and may be legally privileged. It is intended for the addressee(s) only. If you are not the intended recipient, please delete this e-mail and notify the @.@.> : The contents of this e-mail must not be disclosed or copied without the sender's consent. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of the British Library. The British Library does not take any responsibility for the views of the author.

---

Think before you print

[LlGC-szw]

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

[thattonBL]

close please

[LlGC-szw]

Closed at the request of the BL.