universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Metadata for range not displayed

Open lguariento opened this issue 3 years ago • 5 comments

UV version:

[email protected]

I'm submitting a:

  • [x] bug report (possibly a regression)
  • [ ] feature request => please use the user stories repo
  • [ ] support request => Please do not submit support requests here, use stackoverflow

Current behavior: The metadata within a range is not displayed.

Expected behavior: The metadata for the range should be added to the other manifest information to the right hand-side panel.

Steps to reproduce: Open a manifest with ranges in version 4.x, go to the right hand-side panel, check for the range metadata. See here.

Other information: I've used this example.

lguariento avatar Mar 03 '21 13:03 lguariento

I just published v4.0.0-pre.50 which has these changes: https://github.com/UniversalViewer/universalviewer/commit/00344b2e727a40c42184f3e02d678ad63660e91f The more info dialogue is listening for CANVAS_INDEX_CHANGED and re-databinding, which updates the current range.

edsilv avatar Mar 05 '21 11:03 edsilv

In version .50 the metadata for a range is now triggered indeed when clicking on a range title.

It would be great though to also have a header, as per previous versions, something like 'About this part' just to separate the global manifest metadata from the local range metadata.

Also, I suspect the CANVAS_INDEX_CHANGED only gets triggered when... well, clicking on an index. The range-metadata should also be changed when triggering a canvas change, and then check what range that page is part of. Otherwise when you click on an index and then navigate the canvases ahead or backward, and end up in another range, you still have the old metadata displayed.

lguariento avatar Mar 05 '21 12:03 lguariento

Hi @lguariento I'm just working on this and the demo manifests aren't available any more. Are they available at another URL?

edsilv avatar Oct 15 '21 15:10 edsilv

Have put a manifest here: https://friendly-heisenberg-561472.netlify.app/MS_Gen_1042_13.json

edsilv avatar Oct 18 '21 14:10 edsilv

The header is not being shown because rangeHeader is missing here: https://github.com/UniversalViewer/universalviewer/blob/master/src/extensions/uv-seadragon-extension/l10n/en-GB.json#L117

Have added "rangeHeader": "About this section", which will be in the v4 release.

edsilv avatar Oct 19 '21 09:10 edsilv

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

LlGC-szw avatar Aug 25 '23 11:08 LlGC-szw