universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

UV ignoring manifest canvas and image dimensions

Open WilsonAndrewWilson opened this issue 4 years ago • 2 comments

**UV version: **

 all

I'm submitting a:

  • [x] bug report
  • [ ] feature request => please use the user stories repo
  • [ ] support request => Please do not submit support requests here, use stackoverflow

Current behavior: UV uses the image sizes from the info.json of an image, rather than adhering to the canvas or image sizes in the manifest. This means if you change canvas/image sizes in the manifest, it's ignored and it will still just use the info.json image size.

Expected behavior: UV should (?) read the image/canvas sizes and adjust the canvas/image size to that, rather than always using the info.json size.

Steps to reproduce: This manifest has 4 images, arranged in paged viewinghint: https://collections.st-andrews.ac.uk/manifest-test/manifest.json

The middle two pages(viewed 2up) have two different sized canvases/images. The dimensions of the images/canvases match the info of the images from the image api's info.json.

If I change the canvas and image size of one of those two images, the canvas/image sized is ignored, and UV grabs the actual dimensions from info.json then renders the image : https://collections.st-andrews.ac.uk/manifest-test/manifest-same-size.json . 011 For PQ4270.A8B58 leaf * 4 recto was changed to have a width/height of 4668/6432 but UV gets 4329/6063 from the info.json file and renders that instead.

In case it was an issue with trying to render the canvas/image larger than the original image, I also tried to make a larger image smaller. The canvas/image dimensions were also ignored and the original larger image was rendered. https://collections.st-andrews.ac.uk/manifest-test/manifest-same-size-small.json : 010 For PQ4270.A8B58 leaf * 3 verso was reduced in size.

Other information: Changing UV to use the canvas/image dimensions specified in the manifest may have a large impact if UV has never done this previously. Most manifests will have the canvas/image set to the same size as the image from the image api server, but there's still might be cases where the existing behaviour has been relied on.

WilsonAndrewWilson avatar Feb 05 '21 17:02 WilsonAndrewWilson

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

LlGC-szw avatar Aug 25 '23 11:08 LlGC-szw

Still active

thattonBL avatar Sep 28 '23 15:09 thattonBL