universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Semantic structure improvements

Open edsilv opened this issue 5 years ago • 11 comments

Use ARIA-landmarks.

H1 is used for download menu (maybe elsewhere), should be h2.

edsilv avatar Sep 03 '20 16:09 edsilv

Make search result "teardrops" and thumbnails buttons so they appear in tab index?

Edit, use buttons.

edsilv avatar Sep 03 '20 16:09 edsilv

"Contents" and "More Information" should be headings with a role="link"

edsilv avatar Sep 03 '20 16:09 edsilv

Make all span tags with class="label" a label

edsilv avatar Sep 03 '20 16:09 edsilv

I think the highest heading we should use in the UV is h2, under the assumption that the UV will be embedded in a page which will likely use the h1 level.

crhallberg avatar Sep 10 '20 18:09 crhallberg

It's also a matter of if we want a flat hierarchy

Navigation
Index
Thumbnails
Image Viewer/PDF Viewer
Search within
Download

or a richer depth

UV/Content viewer
    Navigation
    Content
        Index
        Thumbnails
    Image Viewer/PDF Viewer
    Search within
    Download

crhallberg avatar Sep 10 '20 18:09 crhallberg

Definitely interested to hear what @edsilv thinks about this, but I wonder if the flat hierarchy is best for starters because it's simpler and easier to apply consistently, and we can always refine it in future if more subtlety is needed.

demiankatz avatar Sep 11 '20 11:09 demiankatz

Agree that flat hierarchy sounds good if it's simpler

edsilv avatar Sep 14 '20 13:09 edsilv

Add title to embedding iframe: https://www.w3.org/TR/UNDERSTANDING-WCAG20/ensure-compat-rsv.html

edsilv avatar Sep 20 '20 14:09 edsilv

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA

In HTML5, all ARIA attributes validate. The new landmark elements (

,
,

I think it would be better to use semantic HTML5 instead of ARIA regions?

edsilv avatar Sep 21 '20 22:09 edsilv

@edsilv, yes, if HTML5 can do the job, don't use ARIA -- it should only be a backup for edge cases where the native support can't fully express the semantics.

demiankatz avatar Sep 22 '20 10:09 demiankatz

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

LlGC-szw avatar Aug 25 '23 11:08 LlGC-szw