universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

gratuitous reloading when clicking on a manifest in a collection

Open eroux opened this issue 6 years ago • 10 comments

Exemplified in http://eroux.fr/buguv2/buguv2.html :

  • open collection "Derge Kangyur" (which unfolds the collection)
  • click on any volume
  • click on another volume

the entire UI gets reloaded and the collection is folded again.

eroux avatar Feb 27 '19 14:02 eroux

(note that looking at the developer console, UV also reruns requests on the collections and manifests URLs. Most of the time they're cached in the browser so it's sort of ok, but I don't think it's a good thing to do)

eroux avatar Feb 27 '19 14:02 eroux

here's a screencast of what I see (Firefox / Linux):

uvbug.zip

eroux avatar Feb 27 '19 14:02 eroux

possibly related: https://github.com/UniversalViewer/universalviewer/issues/603

edsilv avatar Feb 27 '19 16:02 edsilv

I'm seeing gratuitous reloading in the main panel on my site - https://archive.kingsfund.org.uk

ghost avatar Feb 28 '19 10:02 ghost

We're thinking to use https://github.com/edsilv/utils/blob/master/src/Utils.ts#L328 to cache manifests in local storage in manifold here: https://github.com/IIIF-Commons/manifold/blob/master/src/Manifold.ts#L5 (more discussion on #community-sprint https://universalviewer.slack.com/archives/CA2RSMW31/p1562592551084100)

edsilv avatar Jul 24 '19 08:07 edsilv

Great, thanks! That will solve the network calls, but I'm not sure this is really the core of this issue though, which is more a UI reloading problem than a network problem

eroux avatar Jul 24 '19 09:07 eroux

@stephenwf and I have been talking about this. Really we need to think about moving over to webpack or similar. The UV Steering Group call is on Thursday and the roadmap for future community sprints is on the agenda. I think everyone understands that the UV is a very long-running project and in need of a bit of a refresh - it's just how to plan this in a way that works for everyone :-)

edsilv avatar Jul 24 '19 09:07 edsilv

sure! looking at what Mirador does, it sure looks like a big update is a good thing! I can't say I'm not annoyed by being in the space in between an unmaintained Mirador 2 and a not ready Mirador 3, but I still think it's going in the right direction

eroux avatar Jul 24 '19 09:07 eroux

I think the UV is in a good place in terms of being able to incrementally improve (we're calling it the "Ship of Theseus" plan). It's already highly componentised, and TypeScript makes refactors ridiculously easier. At the end of the day the BL, NLW, etc are in for the long haul. We have to move slowly, but (to labour the nautical analogies) we've charted a course and the winds are at our backs :-)

edsilv avatar Jul 24 '19 10:07 edsilv

good to read! :)

eroux avatar Jul 24 '19 11:07 eroux

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

LlGC-szw avatar Aug 25 '23 11:08 LlGC-szw

Closed due to inactivity -- this conversation pre-dates the migration to WebPack.

demiankatz avatar Nov 02 '23 17:11 demiankatz