universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

pressing bookmark button leads to error in the console

Open nicolasfranck opened this issue 7 years ago • 5 comments

UV version:

 [email protected]

I'm submitting a:

  • [x] bug report
  • [ ] feature request => please use the user stories repo
  • [ ] support request => Please do not submit support requests here, use stackoverflow

Current behavior:

If you press the bookmark button an error occurs in the console:

Uncaught TypeError: Cannot set property 'path' of undefined
    at Boolean.<anonymous> (helpers.js:116)
    at UVComponent.BaseComponent.fire (base-component.js:41)
    at Extension.BaseExtension.fire (BaseExtension.js:539)
    at Object.<anonymous> (BaseExtension.js:149)
    at Object.dispatch (offline.js:3)
    at Object.r.handle (offline.js:3)
    at Object.trigger (offline.js:4)
    at Object.<anonymous> (offline.js:4)
    at Function.each (offline.js:2)
    at n.fn.init.each (offline.js:2)

Apparently the callback function in helpers.js is called twice: first with data supplied, and secondly without. That second call fails because the callback assumes data to be provided.

Expected behavior:

Steps to reproduce:

Related code:

// insert any relevant code here

Other information:

nicolasfranck avatar Feb 01 '18 15:02 nicolasfranck

I'm a bit confused - helpers.js was introduced in v3 and this bug is in UV v2.0.1?

edsilv avatar Mar 05 '18 15:03 edsilv

So am I ;-)

v2.0.1 is what was reported in bower.json. But I'm sure this is about v3.

nicolasfranck avatar Mar 05 '18 15:03 nicolasfranck

Some with me, get the error: Cannot set property 'path' of undefined

m-art-in avatar Nov 20 '19 11:11 m-art-in

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

LlGC-szw avatar Aug 25 '23 11:08 LlGC-szw

Still open....

m-art-in avatar Sep 14 '23 13:09 m-art-in