universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

Published 20 hours ago • verified publisher icon UniversalViewer

Global Translations Types

Open crhallberg opened this issue 6 months ago • 2 comments

Progress

  • Added a build step (hooked into build) that creates types for current English translation file.
  • Incorporated that.

TODO

  • [ ] Remove component Content types and content types from Config types.

To Discuss

  • [ ] Do we remove all component translation configs? Pros: can save something like $moreInformation to title. Cons: makes adding new translations complex, duplicate translation strings, excessive types and subtypes.

Resolves #1383.

crhallberg avatar May 19 '25 15:05 crhallberg

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 4:07pm

vercel[bot] avatar May 19 '25 15:05 vercel[bot]

I think it makes sense to commit the type file, so that the types can be imported elsewhere in the codebase. It may also be worth moving it to a generated/ directory so that its clear that they shouldn't be edited - and a place for us to add more.

stephenwf avatar May 20 '25 11:05 stephenwf