UniversalViewer
Add aria labels to toggle expand metadata (fixes issue 1081)
This is a fix for https://github.com/UniversalViewer/universalviewer/issues/1081. It defines strings for aria label prefixes and appends the label text to them (to create the text recommended in the issue comments), applying this string to each toggle button.
It's dependent on some changes to iiif-metadata-component, incorporating https://github.com/IIIF-Commons/iiif-metadata-component/pull/33.
Waiting for French and Polish translations.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| universalviewer | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 23, 2024 4:12pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jamesmisson, I was able to resolve the conflicts here (they were caused by inconsistent indentation in a couple of the locale files). Now the Vercel build is passing! However, when I look at the preview, more buttons seem to be entirely absent, so something is broken (unless we need to wait for other component upgrades before this can work at all).
I have also converted this to a draft to prevent it from getting accidentally merged before the translations are added. :-)
Thanks @demiankatz . the buttons won't appear until the iiif-metadata-component changes are made and imported here (which makes testing this tricky!) https://github.com/IIIF-Commons/iiif-metadata-component/pull/33
@jamesmisson, was this intentionally closed because the work was completed via other PRs, or was it closed by accident because a branch was deleted? (I think it's most likely the former, but just want to be sure it's not the latter :-) ).