react-image-annotate icon indicating copy to clipboard operation
react-image-annotate copied to clipboard

Published 20 hours ago • verified publisher icon UniversalDataTool

Added typescript and update old dependencies to React v.18

Open oleg-yasenytsky opened this issue 10 months ago • 7 comments

oleg-yasenytsky avatar Apr 16 '24 15:04 oleg-yasenytsky

Thanks alot for doing this <3

AlecDusheck avatar May 18 '24 00:05 AlecDusheck

Any chance this could be reviewed and merged in?

wesmorishita avatar May 28 '24 15:05 wesmorishita

@seveibar any chance you can look at this?

alexschultz avatar Aug 02 '24 12:08 alexschultz

Hey guys, taking a look

seveibar avatar Aug 06 '24 18:08 seveibar

Would it be possible to toss this in a branch as-is and add a note in the README saying experimental React 18 support is a work in progress?

AlecDusheck avatar Aug 06 '24 18:08 AlecDusheck

If anyone need package with this pull, i deploy it npm.js https://www.npmjs.com/package/@idapgroup/react-image-annotate

oleg-yasenytsky avatar Aug 08 '24 08:08 oleg-yasenytsky

Would it be possible to toss this in a branch as-is and add a note in the README saying experimental React 18 support is a work in progress?

I'm eager to merge this, but I think my comments are pretty reasonable, for a project this old its good to make sure you don't lose testing surface area, and some of the other changes would misdirect the user, eg the README wouldn't link to user to the npm package published by this repo.

To clarify: I'm very eager to merge and make people maintainers

seveibar avatar Aug 08 '24 15:08 seveibar