react-image-annotate icon indicating copy to clipboard operation
react-image-annotate copied to clipboard

Support React 17

Open jiinjoo opened this issue 3 years ago • 10 comments

React 17 has been released for some 15 months now. Can we add that to the peerDependencies?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from [email protected]
npm ERR! node_modules/react-image-annotate
npm ERR!   react-image-annotate@"^1.8.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

jiinjoo avatar Jan 03 '22 09:01 jiinjoo

Really hoping to help but it's a bit beyond me this maze of dependencies. Some of the underlying dependency upgrades that npm threw at me (even with @HenryLiangzy updates)

  • react-full-screen 0.3.1 needs to go to 1.1.0
  • react-markdown 4.0.6 needs to go to 5, 6, 7, or 8
  • react-monaco-editor 0.25.1 needs to go to 0.47.0 or anything from July 21
  • react-use 13.27.0 needs to go to 17.3.2 (or anything 15 onwards)
  • use-key-hook looks abandoned

jiinjoo avatar Jan 20 '22 23:01 jiinjoo

Hi @jiinjoo I'm working on it but might need some to time test each dependency, if you are able could you provide more detail on which dependencies need to be updated (besides the library that you mentioned before)? Thanks in advance

HenryLiangzy avatar Jan 25 '22 00:01 HenryLiangzy

Am looking into approaches to integrate image data labeling into an application and this seems perfect for my use-case if it supports React 17: any information on when this might be addressed?

bpw1621 avatar Mar 02 '22 02:03 bpw1621

I have the same problem installing it via npm, I tried installing it using yarn, and it worked

SalahHaciAkil avatar Jun 21 '22 08:06 SalahHaciAkil

I am using yarn and having the webpack version issue. Does anyone still working on it? Is there any plan to upgrade to react-script version 5 to support webpack 5 configuration @seveibar

Screenshot 2022-10-13 at 12 15 43 PM

parthpatel303 avatar Oct 13 '22 06:10 parthpatel303

Would accept PR :) not a lot of time to actively work on this project

seveibar avatar Oct 13 '22 06:10 seveibar

@HenryLiangzy Can you please help into this? Thanks!

After installing react-image-annotate, I am getting this error on yarn start

I am using yarn and having the webpack version issue. Does anyone still working on it? Is there any plan to upgrade to react-script version 5 to support webpack 5 configuration @seveibar

Screenshot 2022-10-13 at 12 15 43 PM

parthpatel303 avatar Oct 14 '22 10:10 parthpatel303

Hi, Any update on this issue? Thanks,

nadavof avatar Jan 04 '23 10:01 nadavof

any update to support React 18 ? Or next.js 13 ?

SuhaibMaraqa avatar Dec 18 '23 17:12 SuhaibMaraqa