ml-agents
ml-agents copied to clipboard
SaveJsonTimers shouldn't save to dataPath
Whether performing training or inference, in the editor or standalone, ml-agents saves JSON timer logs into Application.dataPath
, which is the Assets
folder in the editor, or something internal to the executable in standalone. This is a very bad practice, as this folder is meant for read-only data. In development, it makes version control trickier as it adds unnecessary changes within your project files. In production, it potentially makes changes to internal datafiles in released application bundles. I would suggest possibly saving these to Application.persistentDataPath
, or giving an option to specify a different directory or disable this altogether.
Thanks for bringing this to our attention. That's a fair enhancement and I logged it in our internal tracker.