com.unity.netcode.gameobjects icon indicating copy to clipboard operation
com.unity.netcode.gameobjects copied to clipboard

fix: server exception loop

Open slb1988 opened this issue 2 years ago • 2 comments

When NetworkManager.SceneManager.SynchronizeNetworkObjects got exception, there will always got exception in AddClient for add ConnectedClients dictionary multi times. Client and Server all get stuck.

Changelog

  • Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
  • Fixed: If you update multiple packages, create a new section with a new header for the other package.
  • Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go.

Testing and Documentation

  • No tests have been added.
  • Includes unit tests.
  • Includes integration tests.
  • No documentation changes or additions were necessary.
  • Includes documentation for previously-undocumented public API entry points.
  • Includes edits to existing public API documentation.

slb1988 avatar Aug 02 '23 23:08 slb1988

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

unity-cla-assistant avatar Aug 02 '23 23:08 unity-cla-assistant

Interesting... I think I see what you are talking about with that change. Will look at it closer tomorrow....but thank you very much for the PR submission and contributing to help make NGO better!
👍 💯

NoelStephensUnity avatar Aug 03 '23 02:08 NoelStephensUnity