com.unity.netcode.gameobjects icon indicating copy to clipboard operation
com.unity.netcode.gameobjects copied to clipboard

NetworkTransform method SetState seems wrong

Open superztf opened this issue 3 years ago • 2 comments

The method SetState in NetworkTransform assign parameter shouldGhostsInterpolate to IsTeleportingNextFrame.

I think shouldGhostsInterpolate =true means need to interpolate, but IsTeleportingNextFrame=true means not interpolate.

Please check it. Thanks.

superztf avatar Aug 12 '22 08:08 superztf

@superztf Hello! Yeah, I am not that happy with the name myself. On the other hand, you could take a look at PR-2110. If you look at the updates to SetState, you will see that it now inverts that value to denote "not teleporting"... so it makes a little more sense.

Unfortunately, if you have interpolation disabled that property doesn't make sense (IMO).

Since this would change the public facing API, it isn't something we can do for the up-coming patch but we could stand to improve that parameter name next minor version update. 👍

NoelStephensUnity avatar Aug 16 '22 21:08 NoelStephensUnity

Backlog: MTT-4462

ashwinimurt avatar Aug 22 '22 19:08 ashwinimurt

This should be resolved in the coming update (v1.3.0)

NoelStephensUnity avatar Feb 17 '23 23:02 NoelStephensUnity