com.unity.gis.high-precision-framework icon indicating copy to clipboard operation
com.unity.gis.high-precision-framework copied to clipboard

Published 20 hours ago • verified publisher icon Unity-Technologies

Performance - merge transform api calls

Open smitdylan2001 opened this issue 2 years ago • 2 comments

Description

Merged .postion and .rotation calls into SetPositionAndRotation in HPTransform.cs. This will use a single c++ API call instead of 2, which is beneficial for performance.

Also removed empty statement from HPRoot.cs.

Changes made

  • Merged .postion and .rotation calls into SetPositionAndRotation in HPTransform.cs.
  • Removed empty statement from HPRoot.cs.

Checklist

Before review:

  • [x] Changelog entry added under Unreleased section.
    • Explains the change in Modified, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • If UI or rendering results applies, include screenshots.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as Resolved with next release version correctly set.
  • [x] Tests added/changed, if applicable.
    • Functional tests.
    • Performance tests.
    • Integration tests.
  • [x] All Tests passed.
  • [x] Docs for new/changed.
    • XmlDoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
  • [x] The branch name has the respective prefix.
    • bug/ Fixing a bug
    • feature/ New feature implementation
    • perf/ Performance improvement
    • refactor/ A code change that neither fixes a bug nor adds a feature
    • doc/ Added documentation
    • test/ Added Unit Tests
    • build/ Changes that affect the build system or external dependencies
    • ci/ Changes to our CI configuration files and scripts
    • style/ Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • [x] Coding Standards are respected.
  • [x] Rebase the branch if possible.

After review:

  • [x] Squash and Merge
    • If no merge commits are between commits
    • Don't squash commits when they are easier to comprehend the changes when categorized.

smitdylan2001 avatar Aug 15 '22 10:08 smitdylan2001

Could this be checked out soon? It's a 50-70% performance improvement

smitdylan2001 avatar Dec 02 '22 11:12 smitdylan2001

@jdebelle-unity Can you merge this?

smitdylan2001 avatar Mar 14 '23 09:03 smitdylan2001