Improve CPU performance

[smitdylan2001]

Improved CPU performance with:

• Merge .position +.rotation to .SetPositionAndRotation
• Use TryGetComponent for improved garbage allocations
• Simplify string comparisons

[unity-cla-assistant]

All committers have signed the CLA.

[smitdylan2001]

Any chance on getting merged?

[lucillecaillaud]

Hi @smitdylan2001, sorry for the late reply, there is a chance to be merged yes but we would need a bit more info on the actual gain of your changes.

Could you please share:

• What was your setup to compare performances? Did you tried on different asset size, etc?
• Can you share the before/after (maybe screenshot of the Performance editor in Unity) and highlight the performance gain (maybe in different scenario if it changes)?

Thanks!!

[smitdylan2001]

Hi @smitdylan2001, sorry for the late reply, there is a chance to be merged yes but we would need a bit more info on the actual gain of your changes.

Could you please share:

• What was your setup to compare performances? Did you tried on different asset size, etc?
• Can you share the before/after (maybe screenshot of the Performance editor in Unity) and highlight the performance gain (maybe in different scenario if it changes)?

Thanks!!

It's not much noticeable at runtime, and I can only benchmark in a few weeks. I do think that every bit can help with performance, especially if it doesn't change any behaviour

Here are some of the changes benchmarked: https://forum.unity.com/threads/performance-tips.1336262/ The differences between changes can be 50+% for the same line

[smitdylan2001]

If it helps similar changes are made on other Unity repos, like netcode for GO, render pipelines, probuilder and more

[smitdylan2001]

Here's some more info: https://github.com/Unity-Technologies/InputSystem/pull/1578

[smitdylan2001]

@lucillecaillaud any update on a merge?

[smitdylan2001]

Any updates? Would be nice to have this added